Re: [PATCH v1 2/3] dt-bindings: power: sophgo: add Power-On-Reset/POR for Sophgo CV1800 series SoC.

[Krzysztof Kozlowski]

On 29/12/2023 10:06, Jingbao Qiu wrote:
> Add devicetree binding to describe the Power-On-Reset/POR for Sophgo CV1800 SoC.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

Subject: Make it concise. It's way over the limit. Also, unnecessary
full stop.

This all applies to all your patches.

> 

> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx>
> ---

What changed here? Where is the changelog? Did you just ignore entire
feedback from v3?

>  .../bindings/power/sophgo,cv1800-por.yaml     | 29 +++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml
> 
> diff --git a/Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml b/Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml
> new file mode 100644
> index 000000000000..8706230a1cbc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/sophgo,cv1800-por.yaml
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/sophgo,cv1800-por.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Power-On-Reset/POR of the Sophgo CV1800 SoC
> +
> +maintainers:
> +  - Jingbao Qiu <qiujingbao.dlmu@xxxxxxxxx>
> +
> +description:
> +  This hardware provides triggering and timing control
> +  for chip power on, off, and reset.
> +
> +properties:
> +  compatible:
> +    const: sophgo,cv1800-por
> +

Empty schema, drop entire file. You do not need it.

Best regards,
Krzysztof