Re: [PATCH v2] input/vmmouse: Fix device name copies

From: kernel test robot
Date: Thu Jan 04 2024 - 17:01:37 EST


Hi Zack,

kernel test robot noticed the following build errors:

[auto build test ERROR on dtor-input/next]
[also build test ERROR on dtor-input/for-linus linus/master v6.7-rc8 next-20240104]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Zack-Rusin/input-vmmouse-Fix-device-name-copies/20240104-130724
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
patch link: https://lore.kernel.org/r/20240104050605.1773158-1-zack.rusin%40broadcom.com
patch subject: [PATCH v2] input/vmmouse: Fix device name copies
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240105/202401050506.N1aMF9sD-lkp@xxxxxxxxx/config)
compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240105/202401050506.N1aMF9sD-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401050506.N1aMF9sD-lkp@xxxxxxxxx/

All error/warnings (new ones prefixed by >>):

>> drivers/input/mouse/vmmouse.c:78:5: warning: variable length array used [-Wvla]
77 | char phys[sizeof_field(struct serio, phys) +
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
78 | strlen(VMMOUSE_PHYS_NAME_POSTFIX_STR)];
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/input/mouse/vmmouse.c:77:7: error: fields must have a constant size: 'variable length array in structure' extension will never be supported
77 | char phys[sizeof_field(struct serio, phys) +
| ^
1 warning and 1 error generated.


vim +77 drivers/input/mouse/vmmouse.c

67
68 /**
69 * struct vmmouse_data - private data structure for the vmmouse driver
70 *
71 * @abs_dev: "Absolute" device used to report absolute mouse movement.
72 * @phys: Physical path for the absolute device.
73 * @dev_name: Name attribute name for the absolute device.
74 */
75 struct vmmouse_data {
76 struct input_dev *abs_dev;
> 77 char phys[sizeof_field(struct serio, phys) +
> 78 strlen(VMMOUSE_PHYS_NAME_POSTFIX_STR)];
79 char dev_name[128];
80 };
81

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki