Re: [PATCH] drm/mediatek/dp: Add the HDCP feature for DisplayPort

[CK Hu (胡俊光)]

Hi, Mac:

On Fri, 2023-11-24 at 16:53 +0800, mac.shen wrote:
> Add tee client application, HDCP 1.x and 2.x authentication for
> DisplayPort
> to support the HDCP feature.
> 
> Signed-off-by: mac.shen <mac.shen@xxxxxxxxxxxx>
> ---

[snip]

>  
> @@ -2271,7 +2324,7 @@ static void mtk_dp_bridge_atomic_enable(struct
> drm_bridge *bridge,
>  
>  	mtk_dp->enabled = true;
>  	mtk_dp_update_plugged_status(mtk_dp);
> -
> +	mtk_dp_re_authentication(&mtk_dp->hdcp_info);

According to intel HDCP flow [1], I think you should enable HDCP
according to the connector status set by user space.

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/drm/i915/display/intel_hdcp.c?h=next-20240104#n2413

Regards,
CK

>  	return;
>  power_off_aux:
>  	mtk_dp_update_bits(mtk_dp, MTK_DP_TOP_PWR_STATE,
>