Re: [PATCH net-next v2 1/8] octeon_ep_vf: Add driver framework and device initialization
From: Simon Horman
Date: Fri Jan 05 2024 - 05:58:41 EST
On Sat, Dec 23, 2023 at 05:39:53AM -0800, Shinas Rasheed wrote:
> Add driver framework and device setup and initialization for Octeon
> PCI Endpoint NIC VF.
>
> Add implementation to load module, initialize, register network device,
> cleanup and unload module.
>
> Signed-off-by: Shinas Rasheed <srasheed@xxxxxxxxxxx>
Hi Shinas,
a minor nit from my side.
...
> diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h
...
> +#ifndef UINT64_MAX
> +#define UINT64_MAX ((u64)(~((u64)0))) /* 0xFFFFFFFFFFFFFFFF */
> +#endif
nit: UINT64_MAX appears to be unused, so I think it can be removed.
Else, perhaps the code can be updated to use U64_MAX instead.
...