Re: Re: [PATCH] integrity: don't throw an error immediately when failed to add a cert to the .machine keyring

[Coiby Xu]

On Tue, Jan 02, 2024 at 12:54:02PM -0500, Mimi Zohar wrote:
> Hi Coiby,

Hi Mimi,

> According to https://docs.kernel.org/process/submitting-patches.html,the summary line should be no more than  70 - 75 characters.

Thanks for pointing me to this limit! How about 
integrity: eliminate harmless error "Problem loading X.509 certificate -126"?

> On Wed, 2023-12-27 at 12:41 +0800, Coiby Xu wrote:
> > Currently when the kernel fails to add a cert to the .machine keyring,
> > it will throw an error immediately in the function integrity_add_key.
> >
> > Since the kernel will try adding to the .platform keyring next or throw
> > an error (in the caller of integrity_add_key i.e. add_to_machine_keyring),
> > so there is no need to throw an error immediately in integrity_add_key.
> >
> > Reported-by: itrymybest80@xxxxxxxxxxxxxx
> > Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2239331
> > Signed-off-by: Coiby Xu <coxu@xxxxxxxxxx>
>
> Otherwise, the patch looks good.

Thanks for reviewing the patch!

> --
> thanks,
>
> Mim

--
Best regards,
Coiby