Re: [PATCH v4 4/4] arch/x86: Do not include <asm/bootparam.h> in several files

From: kernel test robot
Date: Mon Jan 08 2024 - 19:29:41 EST


Hi Thomas,

kernel test robot noticed the following build errors:

[auto build test ERROR on tip/x86/core]
[also build test ERROR on efi/next tip/master tip/auto-latest linus/master v6.7 next-20240108]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/arch-x86-Move-UAPI-setup-structures-into-setup_data-h/20240108-180158
base: tip/x86/core
patch link: https://lore.kernel.org/r/20240108095903.8427-5-tzimmermann%40suse.de
patch subject: [PATCH v4 4/4] arch/x86: Do not include <asm/bootparam.h> in several files
config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20240109/202401090850.YMrW5H2K-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240109/202401090850.YMrW5H2K-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401090850.YMrW5H2K-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

In file included from arch/x86/boot/compressed/cmdline.c:2:
arch/x86/boot/compressed/misc.h: In function 'sev_enable':
>> arch/x86/boot/compressed/misc.h:154:19: error: invalid use of undefined type 'struct boot_params'
154 | bp->cc_blob_address = 0;
| ^~


vim +154 arch/x86/boot/compressed/misc.h

cec49df9d331fea Joe Millenbach 2012-07-19 135
597cfe48212a3f1 Joerg Roedel 2020-09-07 136 #ifdef CONFIG_AMD_MEM_ENCRYPT
ec1c66af3a30d45 Michael Roth 2022-02-09 137 void sev_enable(struct boot_params *bp);
8c29f0165405325 Nikunj A Dadhania 2023-01-18 138 void snp_check_features(void);
597cfe48212a3f1 Joerg Roedel 2020-09-07 139 void sev_es_shutdown_ghcb(void);
69add17a7c19925 Joerg Roedel 2020-09-07 140 extern bool sev_es_check_ghcb_fault(unsigned long address);
4f9c403e44e5e88 Brijesh Singh 2022-02-09 141 void snp_set_page_private(unsigned long paddr);
4f9c403e44e5e88 Brijesh Singh 2022-02-09 142 void snp_set_page_shared(unsigned long paddr);
76f61e1e89b32f3 Michael Roth 2022-02-24 143 void sev_prep_identity_maps(unsigned long top_level_pgt);
597cfe48212a3f1 Joerg Roedel 2020-09-07 144 #else
4b1c742407571ef Michael Roth 2022-08-23 145 static inline void sev_enable(struct boot_params *bp)
4b1c742407571ef Michael Roth 2022-08-23 146 {
4b1c742407571ef Michael Roth 2022-08-23 147 /*
4b1c742407571ef Michael Roth 2022-08-23 148 * bp->cc_blob_address should only be set by boot/compressed kernel.
4b1c742407571ef Michael Roth 2022-08-23 149 * Initialize it to 0 unconditionally (thus here in this stub too) to
4b1c742407571ef Michael Roth 2022-08-23 150 * ensure that uninitialized values from buggy bootloaders aren't
4b1c742407571ef Michael Roth 2022-08-23 151 * propagated.
4b1c742407571ef Michael Roth 2022-08-23 152 */
4b1c742407571ef Michael Roth 2022-08-23 153 if (bp)
4b1c742407571ef Michael Roth 2022-08-23 @154 bp->cc_blob_address = 0;
4b1c742407571ef Michael Roth 2022-08-23 155 }
8c29f0165405325 Nikunj A Dadhania 2023-01-18 156 static inline void snp_check_features(void) { }
597cfe48212a3f1 Joerg Roedel 2020-09-07 157 static inline void sev_es_shutdown_ghcb(void) { }
69add17a7c19925 Joerg Roedel 2020-09-07 158 static inline bool sev_es_check_ghcb_fault(unsigned long address)
69add17a7c19925 Joerg Roedel 2020-09-07 159 {
69add17a7c19925 Joerg Roedel 2020-09-07 160 return false;
69add17a7c19925 Joerg Roedel 2020-09-07 161 }
4f9c403e44e5e88 Brijesh Singh 2022-02-09 162 static inline void snp_set_page_private(unsigned long paddr) { }
4f9c403e44e5e88 Brijesh Singh 2022-02-09 163 static inline void snp_set_page_shared(unsigned long paddr) { }
76f61e1e89b32f3 Michael Roth 2022-02-24 164 static inline void sev_prep_identity_maps(unsigned long top_level_pgt) { }
597cfe48212a3f1 Joerg Roedel 2020-09-07 165 #endif
597cfe48212a3f1 Joerg Roedel 2020-09-07 166

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki