Re: [GIT PULL] execve updates for v6.8-rc1

From: Linus Torvalds
Date: Mon Jan 08 2024 - 19:31:06 EST


On Mon, 8 Jan 2024 at 16:19, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> Anyway, I want to repeat: this patch is UNTESTED. It compiles for me.

Actually, I take that back. I did a clang build, and clang noted that
my "remove the retval initialization as unnecessary" was wrong,
because the

if (!bprm->fdpath)
goto out_free;

code path in alloc_bprm() still wanted that initial -ENOMEM initialization.

So you need to fix the

int retval;

in alloc_bprm() to be back to the original

int retval = -ENOMEM;

but then it might all work.

Again - note the "might". Somebody needs to actually test it. I may
try to do that in between pulls.

Linus