Re: [PATCH v2] checkpatch: don't complain on _Generic() use

From: Przemek Kitszel
Date: Tue Jan 09 2024 - 02:33:03 EST


On 12/5/23 12:05, Przemek Kitszel wrote:
Improve CamelCase recognition logic to avoid reporting on _Generic() use.

Other C keywords, such as _Bool, are intentionally omitted, as those
should be rather avoided in new source code.

Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>
---
v2: _Static_assert dropped from the scope;
whole word match.

v1 link: https://lkml.org/lkml/2023/11/27/1055
---
scripts/checkpatch.pl | 2 ++
1 file changed, 2 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 25fdb7fda112..1370f426949d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5839,6 +5839,8 @@ sub process {
#CamelCase
if ($var !~ /^$Constant$/ &&
$var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
+#Ignore C keywords
+ $var !~ /^_Generic$/ &&
#Ignore some autogenerated defines and enum values
$var !~ /^(?:[A-Z]+_){1,5}[A-Z]{1,3}[a-z]/ &&
#Ignore Page<foo> variants

base-commit: 3706f141e5639d3034bd83448e929b8462362651

Hi,

could I do anything more to have this patch applied?

Przemek