Re: [PATCH AUTOSEL 4.19 4/7] Input: amimouse - convert to platform remove callback returning void

[Pavel Machek]

Hi!

> From: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> 
> [ Upstream commit 42b8ff47720258d1f6a4412e780a480c139773a0 ]
> 
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart
> from emitting a warning) and this typically results in resource leaks.
> 
> To improve here there is a quest to make the remove callback return
> void. In the first step of this quest all drivers are converted to
> .remove_new(), which already returns void. Eventually after all drivers
> are converted, .remove_new() will be renamed to .remove().
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.

We don't really need this for -stable.

Best regards,
								Pavel

> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> Link: https://lore.kernel.org/r/20231201133747.1099286-2-u.kleine-koenig@xxxxxxxxxxxxxx
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Attachment: signature.asc
Description: PGP signature