Re: [PATCH] arm64: dts: qcom: qcm6490: Update PSCI suspend param for cluster sleep

[Maulik Shah (mkshah)]

On 1/5/2024 3:35 PM, Konrad Dybcio wrote:
> On 5.01.2024 08:02, Maulik Shah wrote:
> > QCM6490 uses Trustzone as firmware whereas SC7280 uses arm trusted
> > firmware. The PSCI suspend param is different in Trustzone for cluster
> > sleep. Update the same for qcm6490 based idp and fairphone fp5 boards.
> >
> > Signed-off-by: Maulik Shah <quic_mkshah@xxxxxxxxxxx>
> > ---
>
> Nice spot!
>
> For things that are chrome-specific, I'd prefer them to be moved to
> -chrome.dtsi and then the "normal" (LA+LE+WP+friends) values to
> stay as default.

Thanks for the review.
Moved the chrome specific changes to sc7280-chrome-common.dtsi in v2.

> >   arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts | 4 ++++
> >   arch/arm64/boot/dts/qcom/qcm6490-idp.dts           | 4 ++++
> >   2 files changed, 8 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> > index 176898c9dbbd..b56f6f26d96f 100644
> > --- a/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> > +++ b/arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts
> > @@ -446,6 +446,10 @@
> >   	};
> >   };
> >   
> > +&CLUSTER_SLEEP_0 {
> > +	arm,psci-suspend-param = <0x4100b344>;
>
> I think the residency times should also be updated here.
>
> Moreover, I'm seeing additional sleep states here (APSS PC, CX RET
> and this one being AOSS SLEEP), with values 0x4<<4, 0x134<<4,
> 0xb34<<4 (the one you added here) respectively.
>
> Could you please add them as well, similar to [1]?
>
> Konrad
>
> [1] https://lore.kernel.org/linux-arm-msm/20230619-topic-sc8280xp-idle-v2-1-cde50bf02f3c@xxxxxxxxxx/

Sure, added additional sleep stats with updated residency time in v2.

Thanks,
Maulik