Re: [PATCH] drm/ci: Add msm tests

[Abhinav Kumar]

On 1/9/2024 7:31 AM, Rob Clark wrote:
> On Mon, Jan 8, 2024 at 6:13 PM Rob Clark <robdclark@xxxxxxxxx> wrote:
> > On Mon, Jan 8, 2024 at 2:58 PM Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx> wrote:
> > > On 1/8/2024 11:50 AM, Rob Clark wrote:
> > > > From: Rob Clark <robdclark@xxxxxxxxxxxx>
> > > >
> > > > The msm tests should skip on non-msm hw, so I think it should be safe to
> > > > enable everywhere.
> > > >
> > > > Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>
> > > > ---
> > > >    drivers/gpu/drm/ci/testlist.txt | 49 +++++++++++++++++++++++++++++++++
> > > >    1 file changed, 49 insertions(+)
> > >
> > > I do see that all these tests use igt_msm_dev_open() to make sure it
> > > opens only the MSM card.
> > >
> > > But if igt_msm_dev_open() fails, I dont see a igt_require() on some of
> > > the tests to skip them. So how will it safely skip on non-msm HW?
> > >
> > > Unless i am missing something here ....
> >
> > hmm, at the time I added the initial msm tests, and
> > igt_msm_dev_open(), I verified that they skipped on intel.. but since
> > then I'd switched from intel to sc8280xp device for primary dev
> > device, so I'd need to re-test to remember how it works.  If these
> > aren't skipping on !msm, it is a bug
>
> I double checked, these tests skip in drm_open_driver() with "No known
> gpu found for chipset flags 0x64 (msm)", so no problem to run them on
> all CI runners.
>
> BR,
> -R

Ack, thanks for checking


Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>

> > BR,
> > -R
> >
> > > > diff --git a/drivers/gpu/drm/ci/testlist.txt b/drivers/gpu/drm/ci/testlist.txt
> > > > index f82cd90372f4..eaeb751bb0ad 100644
> > > > --- a/drivers/gpu/drm/ci/testlist.txt
> > > > +++ b/drivers/gpu/drm/ci/testlist.txt
> > > > @@ -2910,3 +2910,52 @@ kms_writeback@writeback-invalid-parameters
> > > >    kms_writeback@writeback-fb-id
> > > >    kms_writeback@writeback-check-output
> > > >    prime_mmap_kms@buffer-sharing
> > > > +msm_shrink@copy-gpu-sanitycheck-8
> > > > +msm_shrink@copy-gpu-sanitycheck-32
> > > > +msm_shrink@copy-gpu-8
> > > > +msm_shrink@copy-gpu-32
> > > > +msm_shrink@copy-gpu-madvise-8
> > > > +msm_shrink@copy-gpu-madvise-32
> > > > +msm_shrink@copy-gpu-oom-8
> > > > +msm_shrink@copy-gpu-oom-32
> > > > +msm_shrink@copy-mmap-sanitycheck-8
> > > > +msm_shrink@copy-mmap-sanitycheck-32
> > > > +msm_shrink@copy-mmap-8
> > > > +msm_shrink@copy-mmap-32
> > > > +msm_shrink@copy-mmap-madvise-8
> > > > +msm_shrink@copy-mmap-madvise-32
> > > > +msm_shrink@copy-mmap-oom-8
> > > > +msm_shrink@copy-mmap-oom-32
> > > > +msm_shrink@copy-mmap-dmabuf-sanitycheck-8
> > > > +msm_shrink@copy-mmap-dmabuf-sanitycheck-32
> > > > +msm_shrink@copy-mmap-dmabuf-8
> > > > +msm_shrink@copy-mmap-dmabuf-32
> > > > +msm_shrink@copy-mmap-dmabuf-madvise-8
> > > > +msm_shrink@copy-mmap-dmabuf-madvise-32
> > > > +msm_shrink@copy-mmap-dmabuf-oom-8
> > > > +msm_shrink@copy-mmap-dmabuf-oom-32
> > > > +msm_mapping@ring
> > > > +msm_mapping@sqefw
> > > > +msm_mapping@shadow
> > > > +msm_submitoverhead@submitbench-10-bos
> > > > +msm_submitoverhead@submitbench-10-bos-no-implicit-sync
> > > > +msm_submitoverhead@submitbench-100-bos
> > > > +msm_submitoverhead@submitbench-100-bos-no-implicit-sync
> > > > +msm_submitoverhead@submitbench-250-bos
> > > > +msm_submitoverhead@submitbench-250-bos-no-implicit-sync
> > > > +msm_submitoverhead@submitbench-500-bos
> > > > +msm_submitoverhead@submitbench-500-bos-no-implicit-sync
> > > > +msm_submitoverhead@submitbench-1000-bos
> > > > +msm_submitoverhead@submitbench-1000-bos-no-implicit-sync
> > > > +msm_recovery@hangcheck
> > > > +msm_recovery@gpu-fault
> > > > +msm_recovery@gpu-fault-parallel
> > > > +msm_recovery@iova-fault
> > > > +msm_submit@empty-submit
> > > > +msm_submit@invalid-queue-submit
> > > > +msm_submit@invalid-flags-submit
> > > > +msm_submit@invalid-in-fence-submit
> > > > +msm_submit@invalid-duplicate-bo-submit
> > > > +msm_submit@invalid-cmd-idx-submit
> > > > +msm_submit@invalid-cmd-type-submit
> > > > +msm_submit@valid-submit