Re: [PATCH v10 07/50] x86/sev: Add RMP entry lookup helpers

[Borislav Petkov]

On Mon, Dec 18, 2023 at 09:31:50PM -0600, Michael Roth wrote:
> I've moved this to sev.h, but it RMP_PG_SIZE_4K is already defined there
> and used by a bunch of guest code so it's a bit out-of-place to update
> those as part of this patchset. I can send a follow-up series to clean up
> some of the naming and get rid of sev-common.h

Yap, good idea.

> Doesn't seem like it would be an issue, maybe some fallout from any
> files that previously only included sev-common.h and now need to pull in
> guest struct definitions as well, but those definitions don't have a lot
> of external dependencies so don't anticipate any header include
> hellishness. I'll send that as a separate follow-up, along with some of
> the renames you suggested above since they'll touch guest code and
> create unecessary churn for SNP host support.

OTOH, people recently have started looking at including only that stuff
which is really used so having a single header would cause more
preprocessing effort. I'm not too crazy about it as the preprocessing
overhead is barely measurable so might as well have a single header and
then split it later...

Definitely something for the after-burner and not important right now.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette