Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings

[Ninad Palsule]

Hi Conor,

On 1/9/24 11:14, Conor Dooley wrote:
> On Mon, Jan 08, 2024 at 02:05:53PM -0600, Ninad Palsule wrote:
> > Hello Guenter,
> >
> > On 12/12/23 13:50, Guenter Roeck wrote:
> > > On 12/12/23 10:51, Conor Dooley wrote:
> > > > On Tue, Dec 12, 2023 at 10:00:39AM -0800, Guenter Roeck wrote:
> > > > > On Tue, Dec 12, 2023 at 05:15:51PM +0000, Conor Dooley wrote:
> > > > > > On Tue, Dec 12, 2023 at 10:40:03AM -0600, Ninad Palsule wrote:
> > > > > > > From: Joel Stanley <joel@xxxxxxxxx>
> > > > > > >
> > > > > > > The NPCT75x TPM is TIS compatible. It has an I2C and SPI interface.
> > > > > > >
> > > > > > > https://www.nuvoton.com/products/cloud-computing/security/trusted-platform-module-tpm/
> > > > > > >
> > > > > > >
> > > > > > > Add a compatible string for it, and the generic compatible.
> > > > > > >
> > > > > > > OpenBMC-Staging-Count: 3
> > > > > > Delete this from every patch that it appears from.
> >
> > I have send it as a separate commit. https://lore.kernel.org/linux-kernel/20231214144954.3833998-1-ninad@xxxxxxxxxxxxx/
> Why did you do that? It now just adds undocumented compatibles to the
> driver. Please, as Rob requested, work with Lukas on his series to make
> sure that these devices are documented.

I think krzysztof kozlowski suggested to send these patches separately: 
https://lore.kernel.org/linux-kernel/1c5ace65-2fd8-4503-b22f-e0f564d1c83f@xxxxxxxxxx/

Did I misunderstood it? Do you guys want me to include that commit again?

Regards,

Ninad

> Thanks,
> Conor.