Re: [PATCH] tg3: add new module param to force device power down on reboot

[Michael Chan]

On Tue, Jan 9, 2024 at 11:09 PM Heiner Kallweit <hkallweit1@xxxxxxxxx> wrote:
>
> On 10.01.2024 05:12, Pavan Chebbi wrote:
> > I think the second suggestion could be a better solution. Helps to
> > solve the issue 9fc3bc764334 is trying to fix.
> > But I am not sure how easy it is to test. As I recall, Goerge was
> > unable to reach out to the author of 2ca1c94ce0b6 when he wanted to
> > test his patch for regression.
> > We did discuss the risk of this regression.
> > https://patchwork.kernel.org/project/netdevbpf/patch/20231101130418.44164-1-george.shuklin@xxxxxxxxx/
> > Unfortunately, looks like it has come true :(
>
> If the culprit is an unexpected MSI interrupt, then you may also address
> this directly by disabling interrupts in the device. tg3_stop() may be
> a candidate here.
>

We already call dev_close() which will call tg3_close() -> tg3_stop()
a few lines above.

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature