Re: [PATCH v7 1/4] dt-bindings: soc: sophgo: Add Sophgo system control module

From: Krzysztof Kozlowski
Date: Wed Jan 10 2024 - 02:24:33 EST


On 10/01/2024 01:44, Chen Wang wrote:

>>> clocks." may cause misunderstanding. I plan to change it to "The Sophgo
>>> SG2042 SoC system controller provides register information such as
>>> offset, mask and shift to configure related modules such as clock." Is
>>> this better?
>>>
>> Still does not make sense. To provide "offset" means that some other
>> hardware reads sophgo module to get the value of offset. That's not the
>> case here.
>
> I'm probably starting to understand what you mean. How about changing it
> to the following?
>
> The Sophgo system controller is a registers block, providing multiple
> low level platform functions like chip configuration, clock control, etc.

Yes, that sounds good.

Best regards,
Krzysztof