Re: [PATCH v2 1/2] dt-bindings: display: panel: panel-simple: Add compatible property for waveshare 7inch touchscreen panel

[neil . armstrong]

On 09/01/2024 17:32, Conor Dooley wrote:
> On Tue, Jan 09, 2024 at 03:09:48PM +0800, Shengyang Chen wrote:
> > The waveshare 7" 800x480 panel is a clone of Raspberry Pi 7" 800x480 panel
> > It can be drived by Raspberry Pi panel's process but it needs different
> > timing from Raspberry Pi panel. Add compatible property for it.
> >
> > Signed-off-by: Keith Zhao <keith.zhao@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Shengyang Chen <shengyang.chen@xxxxxxxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > index 11422af3477e..02f6b1b2ddc9 100644
> > --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > @@ -335,6 +335,8 @@ properties:
> >         - vivax,tpc9150-panel
> >           # VXT 800x480 color TFT LCD panel
> >         - vxt,vl050-8048nt-c01
> > +        # Waveshare 7" (800x480) touchscreen LCD panel
> > +      - waveshare,7inch-touchscreen
>
> Is "7inch-touchscreen" really a specific enough identifier for this
> device?

Waveshare has very precise SKUs, this should be something like waveshare,7inch-dsi-sku19885 perhaps

Neil

> >           # Winstar Display Corporation 3.5" QVGA (320x240) TFT LCD panel
> >         - winstar,wf35ltiacd
> >           # Yes Optoelectronics YTC700TLAG-05-201C 7" TFT LCD panel
> > --
> > 2.17.1