Re: [PATCH v6 1/2] leds: trigger: netdev: display only supported link speed attribute

From: Lee Jones
Date: Wed Jan 10 2024 - 07:55:21 EST


On Wed, 10 Jan 2024, Christian Marangi wrote:

> On Thu, Dec 21, 2023 at 06:11:24PM +0100, Christian Marangi wrote:
> > With the addition of more link speed mode to the netdev trigger, it was
> > pointed out that there may be a problem with bloating the attribute list
> > with modes that won't ever be supported by the trigger as the attached
> > device name doesn't support them.
> >
> > To clear and address this problem, change the logic where these
> > additional trigger modes are listed.
> >
> > Since the netdev trigger REQUIRE a device name to be set, attach to the
> > device name change function additional logic to parse the supported link
> > speed modes using ethtool APIs and show only the supported link speed
> > modes attribute.
> >
> > Link speed attribute are refreshed on device_name set and on
> > NETDEV_CHANGE events.
> >
> > This only apply to the link speed modes and every other mode is still
> > provided by default.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> > Reviewed-by: Marek Behún <kabel@xxxxxxxxxx>
>
> Any news for this?

Not yet. It's on the list. Holidays, merge window, etc.

--
Lee Jones [李琼斯]