Re: [PATCH v7 1/3] check-uapi: Introduce check-uapi.sh

[John Moon]

On 12/22/2023 9:50 AM, Masahiro Yamada wrote:
> On Tue, Dec 12, 2023 at 11:04 AM John Moon <quic_johmoo@xxxxxxxxxxx> wrote:
>
> The code looks OK. I think it should work as designed.
>
> Line 197 is inconsistently indented by spaces instead of a space,
> but I can fix it up locally.
>
>
> I just thought requiring target commits as positional parameters
> ("check-uapi.sh treeA treeB" just like "git diff treeA treeB")
> might be intuitive, but I guess everything is specified
> by a short option is a design. I can live with that.
>
>
>
> I will wait a few days, and if there is nothing more,
> I will pick up 1/3 and 2/3.

Thank you Masahiro! If anyone else has comments please let me know.

Cheers,
John