Re: [PATCH v8 0/2] PCI: brcmstb: Configure appropriate HW CLKREQ# mode
From: Jim Quinlan
Date: Wed Jan 10 2024 - 13:06:03 EST
On Wed, Dec 13, 2023 at 2:59 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
>
> On Tue, Dec 12, 2023 at 03:51:12PM -0800, Florian Fainelli wrote:
> > On 11/26/23 12:19, Cyril Brulebois wrote:
> > > Hi Jim,
> > >
> > > Jim Quinlan <james.quinlan@xxxxxxxxxxxx> (2023-11-13):
> > > > V8 -- Un-advertise L1SS capability when in "no-l1ss" mode (Bjorn)
> > > > -- Squashed last two commits of v7 (Bjorn)
> > > > -- Fix DT binding description text wrapping (Bjorn)
> > > > -- Fix incorrect Spec reference (Bjorn)
> > > > s/PCIe Spec/PCIe Express Mini CEM 2.1 specification/
> > > > -- Text substitutions (Bjorn)
> > > > s/WRT/With respect to/
> > > > s/Tclron/T_CLRon/
> > > >
> > > > v7 -- Manivannan Sadhasivam suggested (a) making the property look like a
> > > > network phy-mode and (b) keeping the code simple (not counting clkreq
> > > > signal appearances, un-advertising capabilites, etc). This is
> > > > what I have done. The property is now "brcm,clkreq-mode" and
> > > > the values may be one of "safe", "default", and "no-l1ss". The
> > > > default setting is to employ the most capable power savings mode.
> > >
> > > Still:
> > >
> > > Tested-by: Cyril Brulebois <cyril@xxxxxxxxxxx>
> >
> > Thanks Cyril! Bjorn, Lorenzo, any chance this can be applied soon? Thanks!
>
> Seems OK to me if Lorenzo or Krzysztof W. are OK with it.
>
Bjorn,
What is the status of this submission? Stock Linux on RPi4 CM4
systems with a PCIe device panic on boot until this commit is
applied.
Regards,
Jim Quinilan
Broadcom STB/CM