Re: [PATCH] netfs, fscache: Prevent Oops in fscache_put_cache()

[David Howells]

Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

>  	zero = __refcount_dec_and_test(&cache->ref, &ref);
> -	trace_fscache_cache(debug_id, ref - 1, where);
> +	trace_fscache_cache(cache->debug_id, ref - 1, where);

You can't do that if !zero.  cache may be deallocated between the two lines.

David