Re: [PATCH v22 6/8] dt-bindings: clock: npcm845: replace reg with syscon property

[Krzysztof Kozlowski]

On 08/01/2024 14:54, Tomer Maimon wrote:
> Replace reg with syscon property since the clock registers handle the
> reset registers as well.
> 
> Signed-off-by: Tomer Maimon <tmaimon77@xxxxxxxxx>
> ---
>  .../bindings/clock/nuvoton,npcm845-clk.yaml   | 22 +++++++++----------
>  1 file changed, 10 insertions(+), 12 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> index 0b642bfce292..c6bf05c163b4 100644
> --- a/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> +++ b/Documentation/devicetree/bindings/clock/nuvoton,npcm845-clk.yaml
> @@ -18,8 +18,9 @@ properties:
>      enum:
>        - nuvoton,npcm845-clk
>  
> -  reg:
> -    maxItems: 1
> +  nuvoton,sysclk:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: phandle to access clock registers.

NAK. Not explained, not justified, not reasonable, breaking ABI.

Best regards,
Krzysztof