Re: [PATCH] drm/edid: Clean up errors in drm_edid.h

[Jani Nikula]

On Thu, 11 Jan 2024, chenxuebing <chenxb_99091@xxxxxxx> wrote:
> Fix the following errors reported by checkpatch:
>
> ERROR: do not use assignment in if condition
>
> Signed-off-by: chenxuebing <chenxb_99091@xxxxxxx>

Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>

> ---
>  drivers/gpu/drm/drm_edid.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 69c68804023f..9bcaf76f10fc 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -3611,7 +3611,8 @@ static bool mode_in_range(const struct drm_display_mode *mode,
>  	if (!mode_in_vsync_range(mode, edid, t))
>  		return false;
>  
> -	if ((max_clock = range_pixel_clock(edid, t)))
> +	max_clock = range_pixel_clock(edid, t);
> +	if (max_clock)
>  		if (mode->clock > max_clock)
>  			return false;

-- 
Jani Nikula, Intel