Re: (subset) [PATCH v8 0/7] Add support for LUT PPG

[Lee Jones]

On Thu, 21 Dec 2023 10:58:30 -0800, Anjelique Melendez wrote:
> In certain PMICs, LUT pattern and LPG configuration is stored in SDAM
> modules instead of LUT peripheral. This feature is called PPG.
> 
> This change series adds support for PPG. Thanks!
> Changes since v7:
>   - Patch 4/7
>     - Initialize hi/lo_pause variables in lpg_pattern_set()
> Changes since v6:
>   - Patch 2/7
>     - Removed required by constraint on PPG dt properties
> Changes since v5:
>   - Patch 4/7
>     - Update logic so that multicolor led device triggers pattern
>       on all LEDs at the same time
>     - Update nitpicks from Lee
>   - Patch 5/7
>     - Update nitpicks from Lee
> Changes since v4:
>   - Patch 3/7
>     - Get rid of r/w helpers
>     - Use regmap_read_poll_timeout() in qcom_pbs_wait_for_ack()
>     - Update error path in qcom_pbs_trigger_event()
>     - Fix reverse christmas tree
>   - Patch 4/7
>     - Get rid of r/w helpers
>     - Update variables to use "sdam" instead of "nvmem"
>     - Fix comments
>     - Fix reverse christmas tree
>     - Update lpg_pattern_set() logic
>   - Patch 5/7
>     - Removed sdam_lut_base from lpg_data
> Changes since v3:
>   - Patch 4/7
>     - Fix function returns
>     - Move register definition to top of file
>     - Revert max_brightness and probe accidental changes
>     - Combine init_sdam() and parse_sdam()
>     - Change error prints in probe to use dev_err_probe
>     - Remove ppg_en variable
>     - Update when pbs triggers are set/cleared
>   - Patch 6/7
>     - Remove use of nvmem_count
>     - Move register definition to top of file
>     - Remove lpg_get_sdam_lut_idx()
> Changes since v2:
>   - Patch 1/7
>     - Fix dt_binding_check error
>     - Rename binding file to match compatible
>     - Iclude SoC specific comptaibles
>   - Patch 2/7
>     - Update nvmem-names list
>   - Patch 3/7
>     - Update EXPORT_SYMBOL to EXPORT_SYMBOL_GPL
>     - Fix return/break logic in qcom_pbs_wait_for_ack()
>     - Update iterators to be int
>     - Add constants
>     - Fix function calls in qcom_pbs_trigger_event()
>     - Remove unnessary comments
>     - Return -EPROBE_DEFER from get_pbs_client_device()
> Changes since v1:
>   - Patch 1/7
>     - Fix dt_binding_check errors
>     - Update binding description
>   - Path 2/7
>     - Fix dt_binding_check errors
>     - Update per variant constraints
>     - Update nvmem description
>   - Patch 3/7
>     - Update get_pbs_client_device()
>     - Drop use of printk
>     - Remove unused function
> 
> [...]

Applied, thanks!

[2/7] dt-bindings: leds: leds-qcom-lpg: Add support for LPG PPG
      commit: 2fdd08fec742e0c94a2a06a0c9ee0912b6f7ac39
[4/7] leds: rgb: leds-qcom-lpg: Add support for PPG through single SDAM
      commit: 07a1afc8fbb77cc893e2285112482902ac88a295
[5/7] leds: rgb: leds-qcom-lpg: Update PMI632 lpg_data to support PPG
      commit: f4f5f6a6f8d7bcc8efd0eee6751def22c9a38fd0
[6/7] leds: rgb: leds-qcom-lpg: Include support for PPG with dedicated LUT SDAM
      commit: 7399a927272de1fc42f4da8af1d8d60b65a15b84
[7/7] leds: rgb: Update PM8350C lpg_data to support two-nvmem PPG Scheme
      commit: 7b4066868689b1f341e61957611d252b6fa8cafc

--
Lee Jones [李琼斯]