Re: [PATCH] mm: Update mark_victim tracepoints fields

[kernel test robot]

Hi Carlos,

kernel test robot noticed the following build errors:

[auto build test ERROR on 0dd3ee31125508cd67f7e7172247f05b7fd1753a]

url:    https://github.com/intel-lab-lkp/linux/commits/Carlos-Galo/mm-Update-mark_victim-tracepoints-fields/20240111-081635
base:   0dd3ee31125508cd67f7e7172247f05b7fd1753a
patch link:    https://lore.kernel.org/r/20240111001155.746-1-carlosgalo%40google.com
patch subject: [PATCH] mm: Update mark_victim tracepoints fields
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20240111/202401112057.lJYUSJJe-lkp@xxxxxxxxx/config)
compiler: ClangBuiltLinux clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240111/202401112057.lJYUSJJe-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401112057.lJYUSJJe-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

   In file included from mm/oom_kill.c:54:
   In file included from include/trace/events/oom.h:206:
   In file included from include/trace/define_trace.h:102:
   In file included from include/trace/trace_events.h:237:
>> include/trace/events/oom.h:96:3: error: called object type 'uid_t' (aka 'unsigned int') is not a function or function pointer
      74 |         ),
         |         ~~
      75 | 
      76 |         TP_fast_assign(
         |         ~~~~~~~~~~~~~~~
      77 |                 __entry->pid = task->pid;
         |                 ~~~~~~~~~~~~~~~~~~~~~~~~~
      78 |                 __entry->uid = uid;
         |                 ~~~~~~~~~~~~~~~~~~~
      79 |                 __assign_str(comm, task->comm);
         |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      80 |                 __entry->oom_score_adj = task->signal->oom_score_adj;
         |                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      81 |         ),
         |         ~~
      82 | 
      83 |         TP_printk("pid=%d uid=%u comm=%s oom_score_adj=%hd",
         |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      84 |                 __entry->pid,
         |                 ~~~~~~~~~~~~~
      85 |                 __entry->uid
         |                 ~~~~~~~~~~~~
      86 |                 __get_str(comm),
         |                 ^~~~~~~~~~~~~~~~
      87 |                 __entry->oom_score_adj,
         |                 ~~~~~~~~~~~~~~~~~~~~~~~
      88 |         )
         |         ~
      89 | );
         | ~
   include/trace/stages/stage3_trace_output.h:20:26: note: expanded from macro '__get_str'
      20 | #define __get_str(field) ((char *)__get_dynamic_array(field))
         |                          ^
   include/trace/stages/stage3_trace_output.h:9:43: note: expanded from macro 'TP_printk'
       9 | #define TP_printk(fmt, args...) fmt "\n", args
         |                                           ^
   include/trace/trace_events.h:45:16: note: expanded from macro 'TRACE_EVENT'
      40 |         DECLARE_EVENT_CLASS(name,                              \
         |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      41 |                              PARAMS(proto),                    \
         |                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      42 |                              PARAMS(args),                     \
         |                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      43 |                              PARAMS(tstruct),                  \
         |                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      44 |                              PARAMS(assign),                   \
         |                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      45 |                              PARAMS(print));                   \
         |                              ~~~~~~~^~~~~~~
   include/linux/tracepoint.h:107:25: note: expanded from macro 'PARAMS'
     107 | #define PARAMS(args...) args
         |                         ^
   include/trace/trace_events.h:203:27: note: expanded from macro 'DECLARE_EVENT_CLASS'
     203 |         trace_event_printf(iter, print);                                \
         |                                  ^~~~~
   In file included from mm/oom_kill.c:54:
   In file included from include/trace/events/oom.h:206:
   In file included from include/trace/define_trace.h:102:
   In file included from include/trace/trace_events.h:237:
>> include/trace/events/oom.h:74:1: error: expected expression
      74 | TRACE_EVENT(mark_victim,
         | ^
   include/trace/trace_events.h:40:2: note: expanded from macro 'TRACE_EVENT'
      40 |         DECLARE_EVENT_CLASS(name,                              \
         |         ^
   include/trace/trace_events.h:203:32: note: expanded from macro 'DECLARE_EVENT_CLASS'
     203 |         trace_event_printf(iter, print);                                \
         |                                       ^
   2 errors generated.


vim +96 include/trace/events/oom.h

    73	
  > 74	TRACE_EVENT(mark_victim,
    75		TP_PROTO(struct task_struct *task, uid_t uid),
    76	
    77		TP_ARGS(task, uid),
    78	
    79		TP_STRUCT__entry(
    80			__field(int, pid)
    81			__field(uid_t, uid)
    82			__string(comm, task->comm)
    83			__field(short, oom_score_adj)
    84		),
    85	
    86		TP_fast_assign(
    87			__entry->pid = task->pid;
    88			__entry->uid = uid;
    89			__assign_str(comm, task->comm);
    90			__entry->oom_score_adj = task->signal->oom_score_adj;
    91		),
    92	
    93		TP_printk("pid=%d uid=%u comm=%s oom_score_adj=%hd",
    94			__entry->pid,
    95			__entry->uid
  > 96			__get_str(comm),
    97			__entry->oom_score_adj,
    98		)
    99	);
   100	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki