Re: [PATCH 1/3] wifi: ath12k: Remove unnecessary struct qmi_txn initializers

[Kalle Valo]

Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> wrote:

> Currently most of the ath12k QMI messaging functions define their
> struct qmi_txn variables with a {} initializer. However, all of these
> functions subsequently call qmi_txn_init(), and the very first thing
> that function does is zero the struct. Hence, the initializers are
> unnecessary. Since these consume code space and cpu cycles, remove
> them.
> 
> No functional changes, compile tested only.

s-o-b missing on all 3 patches.

3 patches set to Changes Requested.

13515170 [1/3] wifi: ath12k: Remove unnecessary struct qmi_txn initializers
13515167 [2/3] wifi: ath12k: Add missing qmi_txn_cancel() calls
13515168 [3/3] wifi: ath12k: Use initializers for QMI message buffers

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240109-qmi-cleanup-v1-1-607b10858566@xxxxxxxxxxx/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches