Re: [PATCH] block: print symbolic error name instead of error code

[Damien Le Moal]

On 1/12/24 08:15, Christian Heusel wrote:
> Utilize the %pe print specifier to get the symbolic error name as a
> string (i.e "-ENOMEM") in the log message instead of the error code to
> increase its readablility.
> 
> This change was suggested in
> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mountain/
> 
> Signed-off-by: Christian Heusel <christian@xxxxxxxxx>
> ---
>  block/partitions/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/block/partitions/core.c b/block/partitions/core.c
> index f47ffcfdfcec..932df4db76f1 100644
> --- a/block/partitions/core.c
> +++ b/block/partitions/core.c
> @@ -570,8 +570,8 @@ static bool blk_add_partition(struct gendisk *disk,
>  	part = add_partition(disk, p, from, size, state->parts[p].flags,
>  			     &state->parts[p].info);
>  	if (IS_ERR(part) && PTR_ERR(part) != -ENXIO) {
> -		printk(KERN_ERR " %s: p%d could not be added: %ld\n",
> -		       disk->disk_name, p, -PTR_ERR(part));
> +		printk(KERN_ERR " %s: p%d could not be added: %pe\n",
> +		       disk->disk_name, p, part);

pr_err() ?

>  		return true;
>  	}
>  

-- 
Damien Le Moal
Western Digital Research