Re: [PATCH] block: print symbolic error name instead of error code
From: Jens Axboe
Date: Thu Jan 11 2024 - 19:12:27 EST
On 1/11/24 4:56 PM, Christian Heusel wrote:
> On 24/01/12 08:37AM, Damien Le Moal wrote:
>> On 1/12/24 08:15, Christian Heusel wrote:
>>> - printk(KERN_ERR " %s: p%d could not be added: %ld\n",
>>> - disk->disk_name, p, -PTR_ERR(part));
>>> + printk(KERN_ERR " %s: p%d could not be added: %pe\n",
>>> + disk->disk_name, p, part);
>>
>> pr_err() ?
>
> If desired I can send a v2 containing another patch which refactors the
> usages of printk into their respective pr_* aliases, but I wanted to
> keep this consistent to the usages in rest of the file and do one change
> at a time.
Yes let's please keep that separate, not a huge fan of conversions of that
anyway as it just causes backports or stable kernel issues.
--
Jens Axboe