Re: [PATCH v3 2/3] x86/mm: Regularize set_memory_p() parameters and make non-static

[Edgecombe, Rick P]

On Fri, 2024-01-05 at 10:30 -0800, mhkelley58@xxxxxxxxx wrote:
> From: Michael Kelley <mhklinux@xxxxxxxxxxx>
> 
> set_memory_p() is currently static.  It has parameters that don't
> match set_memory_p() under arch/powerpc and that aren't congruent
> with the other set_memory_* functions. There's no good reason for
> the difference.
> 
> Fix this by making the parameters consistent, and update the one
> existing call site.  Make the function non-static and add it to
> include/asm/set_memory.h so that it is completely parallel to
> set_memory_np() and is usable in other modules.
> 
> No functional change.
> 
> Signed-off-by: Michael Kelley <mhklinux@xxxxxxxxxxx>

Reviewed-by: Rick Edgecombe <rick.p.edgecombe@xxxxxxxxx>