Re: [PATCH v1 2/2] mm:vmscan: fix shrink sc parameters issue

[zhiguojiang]

在 2024/1/11 21:43, Johannes Weiner 写道:
> On Thu, Jan 11, 2024 at 08:24:51PM +0800, Zhiguo Jiang wrote:
> > The values of struct scan_control's members obtained by
> > prepare_scan_control() are always from root_mem_cgroup, rather than
> > the memcg where the shrinked folio is actually located, such as
> > sc->anon_cost, sc->file_cost, sc->may_deactivate and so on. This is
> > an inaccurate sc values for the actual situation of the current
> > shrinking memcg. so we need fix the values of struct scan_control's
> > members are corresponding to the current shrinking memcg.
> You don't seem to understand how cgroup reclaim works.
It seems that the actual memcg's lruvec->anon_cost/file_cost values are 
not used in code exclude target_memcg ?
> Nacked-by: Johannes Weiner <hannes@xxxxxxxxxxx>