Re: [PATCH v3] Documentation: KUnit: Update the instructions on how to test static functions

From: David Gow
Date: Thu Jan 11 2024 - 23:34:51 EST


On Thu, 11 Jan 2024 at 01:39, Arthur Grillo <arthurgrillo@xxxxxxxxxx> wrote:
>
> Now that we have the VISIBLE_IF_KUNIT and EXPORT_SYMBOL_IF_KUNIT macros,
> update the instructions to recommend this way of testing static
> functions.
>
> Signed-off-by: Arthur Grillo <arthurgrillo@xxxxxxxxxx>
> ---
> Changes in v3:
> - Maintain the old '#include' way
> - Link to v2: https://lore.kernel.org/r/20240108-kunit-doc-export-v2-1-8f2dd3395fed@xxxxxxxxxx
>
> Changes in v2:
> - Fix #if condition
> - Link to v1: https://lore.kernel.org/r/20240108-kunit-doc-export-v1-1-119368df0d96@xxxxxxxxxx
> ---

This looks good, thanks!

Reviewed-by: David Gow <davidgow@xxxxxxxxxx>

We may try to add some more reference documentation for the
visibility.h header later on, but this example is probably more useful
anyway.

Cheers,
-- David

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature