Re: [PATCH 10/13] iio: buffer: dmaengine: export devm_iio_dmaengine_buffer_alloc()
From: David Lechner
Date: Fri Jan 12 2024 - 09:55:53 EST
On Fri, Jan 12, 2024 at 6:38 AM Jonathan Cameron
<Jonathan.Cameron@xxxxxxxxxx> wrote:
>
> On Wed, 10 Jan 2024 13:49:51 -0600
> David Lechner <dlechner@xxxxxxxxxxxx> wrote:
>
> > This changes devm_iio_dmaengine_buffer_alloc() to an exported symbol.
> > This will be used by drivers that need to allocate a DMA buffer without
> > attaching it to an IIO device.
> >
> > Signed-off-by: David Lechner <dlechner@xxxxxxxxxxxx>
> > ---
> > Documentation/driver-api/driver-model/devres.rst | 1 +
> > drivers/iio/buffer/Kconfig | 14 +++++++-------
> > drivers/iio/buffer/industrialio-buffer-dmaengine.c | 3 ++-
> > include/linux/iio/buffer-dmaengine.h | 2 ++
> > 4 files changed, 12 insertions(+), 8 deletions(-)
> >
> > diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst
> > index b23d4a2b68a6..60e4b7ba38e5 100644
> > --- a/Documentation/driver-api/driver-model/devres.rst
> > +++ b/Documentation/driver-api/driver-model/devres.rst
> > @@ -285,6 +285,7 @@ I2C
> > IIO
> > devm_iio_device_alloc()
> > devm_iio_device_register()
> > + devm_iio_dmaengine_buffer_alloc()
> > devm_iio_dmaengine_buffer_setup()
> > devm_iio_kfifo_buffer_setup()
> > devm_iio_kfifo_buffer_setup_ext()
> > diff --git a/drivers/iio/buffer/Kconfig b/drivers/iio/buffer/Kconfig
> > index 925c5bf074bc..27d82fb4bc4d 100644
> > --- a/drivers/iio/buffer/Kconfig
> > +++ b/drivers/iio/buffer/Kconfig
> > @@ -40,6 +40,13 @@ config IIO_BUFFER_HW_CONSUMER
> > Should be selected by drivers that want to use the generic Hw consumer
> > interface.
> >
> > +config IIO_HW_TRIGGERED_BUFFER
> > + tristate "Industrial I/O hardware triggered buffer support"
> > + select AUXILIARY_BUS
> > + select IIO_TRIGGER
> > + help
> > + Provides helper functions for setting up hardware triggered buffers.
> > +
> > config IIO_KFIFO_BUF
> > tristate "Industrial I/O buffering based on kfifo"
> > help
> > @@ -53,10 +60,3 @@ config IIO_TRIGGERED_BUFFER
> > select IIO_KFIFO_BUF
> > help
> > Provides helper functions for setting up triggered buffers.
> > -
> > -config IIO_HW_TRIGGERED_BUFFER
> > - tristate "Industrial I/O hardware triggered buffer support"
> > - select AUXILIARY_BUS
> > - select IIO_TRIGGER
> > - help
> > - Provides helper functions for setting up hardware triggered buffers.
>
> Why move this?
>
Oops, this shouldn't be here. Looks like an artifact from a botched
rebase. The intention was to put it in alphabetical order.