RE: [PATCH 01/12] selftests/net: Add TCP-AO library

[Nassiri, Mohammad]

Hi Dmitry,

First, thank you for submitting this very helpful set of tcp-ao selftests!

>-----Original Message-----
>From: Dmitry Safonov <dima@xxxxxxxxxx>
>Sent: Thursday, December 14, 2023 9:36 PM
>To: Shuah Khan <shuah@xxxxxxxxxx>; David Ahern <dsahern@xxxxxxxxxx>;
>David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
><edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni
><pabeni@xxxxxxxxxx>
>Cc: Dmitry Safonov <dima@xxxxxxxxxx>; Salam Noureddine
><noureddine@xxxxxxxxxx>; Bob Gilligan <gilligan@xxxxxxxxxx>; linux-
>kernel@xxxxxxxxxxxxxxx; linux-kselftest@xxxxxxxxxxxxxxx;
>netdev@xxxxxxxxxxxxxxx; Dmitry Safonov <0x7f454c46@xxxxxxxxx>
>Subject: [PATCH 01/12] selftests/net: Add TCP-AO library
>
>Provide functions to create selftests dedicated to TCP-AO.
>They can run in parallel, as they use temporary net namespaces.
>They can be very specific to the feature being tested.
>This will allow to create a lot of TCP-AO tests, without complicating
>one binary with many --options and to create scenarios, that are
>hard to put in bash script that uses one binary.
>
>Signed-off-by: Dmitry Safonov <dima@xxxxxxxxxx>


>+	key_dump[0].nkeys = nr_keys;
>+	key_dump[0].get_all = 1;
>+	key_dump[0].get_all = 1;

Duplicate assignment of get_all.

>+	err = getsockopt(sk, IPPROTO_TCP, TCP_AO_GET_KEYS,
>+			 key_dump, &key_dump_sz);
>+	if (err) {
>+		free(key_dump);
>+		return -errno;
>+	}
>+}
>+
>+const struct sockaddr_in6 addr_any6 = {
>+	.sin6_family	= AF_INET6,
>+};
>+
>+const struct sockaddr_in addr_any4 = {
>+	.sin_family	= AF_INET,
>+};
>
>--
>2.43.0

Mohammad