Re: [PATCH] linux/export.h: remove unneeded .balign directive

[Masahiro Yamada]

On Thu, Jan 11, 2024 at 8:11 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> On Wed, Jan 03, 2024 at 10:54:54PM +0900, Masahiro Yamada wrote:
> > The .export_symbol section is discarded by the linker script, hence
> > no alignment is needed. Simplify the code.
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
>
> With this patch in linux-next, all sh4 builds fail.


Thanks.
I dropped it.







>
> Building sh:defconfig ... failed
> --------------
> Error log:
> <stdin>:1519:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> {standard input}: Assembler messages:
> {standard input}:6: Error: misaligned data
> {standard input}:7: Error: misaligned data
> {standard input}:8: Error: misaligned data
> make[6]: *** [scripts/Makefile.build:243: arch/sh/boards/mach-x3proto/ilsel.o] Error 1
>
> Reverting this patch fixes the problem.
>
> Guenter
>
> ---
> # bad: [8cb47d7cd090a690c1785385b2f3d407d4a53ad0] Add linux-next specific files for 20240110
> # good: [0dd3ee31125508cd67f7e7172247f05b7fd1753a] Linux 6.7
> git bisect start 'HEAD' 'v6.7'
> # bad: [b14da9dd6f977c6e18a4c81e4b92692fd9b6997f] Merge branch 'main' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git
> git bisect bad b14da9dd6f977c6e18a4c81e4b92692fd9b6997f
> # bad: [e85ebbed67d0d74e8602d11a496183d8f65e0b2f] Merge branch 'for-next' of https://evilpiepirate.org/git/bcachefs.git
> git bisect bad e85ebbed67d0d74e8602d11a496183d8f65e0b2f
> # bad: [65d7e41dbca9e31017cfd36c2ce4cb8408b1f2c6] Merge branch 'perf-tools-next' of git://git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git
> git bisect bad 65d7e41dbca9e31017cfd36c2ce4cb8408b1f2c6
> # good: [fb46e22a9e3863e08aef8815df9f17d0f4b9aede] Merge tag 'mm-stable-2024-01-08-15-31' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
> git bisect good fb46e22a9e3863e08aef8815df9f17d0f4b9aede
> # good: [fd38dd6abda589a8771e7872e4dea28c99c6a6ef] kselftest/alsa - conf: Stringify the printed errno in sysfs_get()
> git bisect good fd38dd6abda589a8771e7872e4dea28c99c6a6ef
> # good: [8a0bd6d47301eefd80fdfeb3a00ec09011546155] Merge branch 'mtd/fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
> git bisect good 8a0bd6d47301eefd80fdfeb3a00ec09011546155
> # good: [16f533ade706d33e60324ff32e526bda20bccbd9] perf unwind: Use function to add missing maps lock
> git bisect good 16f533ade706d33e60324ff32e526bda20bccbd9
> # bad: [c6113f13957f918762d54080b2e2adbe0d7889e5] linux/export.h: remove unneeded .balign directive
> git bisect bad c6113f13957f918762d54080b2e2adbe0d7889e5
> # good: [d821f8a26efb6789666d70ce7a8f27df6c33c12e] sparc: vdso: use $(addprefix ) instead of $(foreach )
> git bisect good d821f8a26efb6789666d70ce7a8f27df6c33c12e
> # good: [9c65810cfb215f40f14d2c00694911fbc5408761] kbuild: deb-pkg: split debian/copyright from the mkdebian script
> git bisect good 9c65810cfb215f40f14d2c00694911fbc5408761
> # good: [5e73758b43c3defba2578df6d3a53e942fa6b41e] kbuild: deb-pkg: use more debhelper commands in builddeb
> git bisect good 5e73758b43c3defba2578df6d3a53e942fa6b41e
> # good: [343f74e7779c482c2fd4492cc6b45c64e18fe321] kbuild: deb-pkg: make debian/rules quiet by default
> git bisect good 343f74e7779c482c2fd4492cc6b45c64e18fe321
> # good: [0832e9bcfb0dc48833bbc8054cdc9b697afa8cd9] kbuild: deb-pkg: build binary-arch in parallel
> git bisect good 0832e9bcfb0dc48833bbc8054cdc9b697afa8cd9
> # good: [53bc4fa98f8dd5ccca9a8e038660bf0d30d9e22d] kbuild: deb-pkg: call more misc debhelper commands
> git bisect good 53bc4fa98f8dd5ccca9a8e038660bf0d30d9e22d
> # first bad commit: [c6113f13957f918762d54080b2e2adbe0d7889e5] linux/export.h: remove unneeded .balign directive



-- 
Best Regards
Masahiro Yamada