Re: [PATCH v9 02/10] mm: Non-pmd-mappable, large folios for folio_add_new_anon_rmap()

[David Hildenbrand]

> > > diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
> > > index 485bb0389b488..929e98c629652 100644
> > > --- a/kernel/events/uprobes.c
> > > +++ b/kernel/events/uprobes.c
> > > @@ -537,7 +537,7 @@ int uprobe_write_opcode(struct arch_uprobe *auprobe, struct mm_struct *mm,
> > >   		}
> > >   	}
> > > -	ret = __replace_page(vma, vaddr, old_page, new_page);
> > > +	ret = __replace_page(vma, vaddr & PAGE_MASK, old_page, new_page);
> > >   	if (new_page)
> > >   		put_page(new_page);
> > >   put_old:
> > > diff --git a/mm/rmap.c b/mm/rmap.c
> > > index f5d43edad529a..a903db4df6b97 100644
> > > --- a/mm/rmap.c
> > > +++ b/mm/rmap.c
> > > @@ -1408,6 +1408,7 @@ void folio_add_new_anon_rmap(struct folio *folio, struct vm_area_struct *vma,
> > >   {
> > >   	int nr = folio_nr_pages(folio);
> > > +	VM_WARN_ON_FOLIO(!IS_ALIGNED(address, PAGE_SIZE), folio);
>
> nit: Is it worth also adding this to __folio_add_anon_rmap() so that
> folio_add_anon_rmap_ptes() and folio_add_anon_rmap_pmd() also benefit?

Yes, same thoughts. Just included it so we would catch if still 
something goes wrong here.

I'll split that change out either way.


> Regardless:
>
> Reviewed-by: Ryan Roberts <ryan.roberts@xxxxxxx>

Thanks!

--
Cheers,

David / dhildenb