Re: [PATCH v5] arm64: dts: qcom: qcm6490-idp: Add definition for three LEDs

[hui liu]

On 1/15/2024 5:56 PM, Dmitry Baryshkov wrote:
> On Mon, 15 Jan 2024 at 11:48, Hui Liu via B4 Relay
> <devnull+quic_huliu.quicinc.com@xxxxxxxxxx> wrote:
> > From: Hui Liu <quic_huliu@xxxxxxxxxxx>
> >
> > Add definition for three LEDs to make sure they can
> > be enabled base on QCOM LPG LED driver.
>
> The "function" property is still placed incorrectly. Posting the next
> iteration before concluding the discussion on the previous one is not
> the best idea.
Do you mean I should update it as below? Seems there is no consumer to 
use the function config, do we need to add now?
pm8350c_pwm {
 +       function = LED_FUNCTION_STATUS;
 +       #address-cells = <1>;
 +       #size-cells = <0>;
 +       status = "okay";
 +
 +       led@1 {
 +               reg = <1>;
 +               color = <LED_COLOR_ID_RED>;
 +		 function = LED_FUNCTION_STATUS;
 +       };
 + ...

> > Signed-off-by: Hui Liu <quic_huliu@xxxxxxxxxxx>
> > ---
> > Changes in v5:
> > - Rephrased commit text, replaced qcs6490-idp to qcm6490-idp.
> > - Removed the unnecessary full.
> > - Link to v4: https://lore.kernel.org/r/20240112-lpg-v4-1-c4004026686b@xxxxxxxxxxx
> >
> > Changes in v4:
> > - Removed "label" definition and added "function" definition.
> > - Link to v3: https://lore.kernel.org/r/20231215-lpg-v3-1-4e2db0c6df5f@xxxxxxxxxxx
> >
> > Changes in v3:
> > - Rephrased commit text and updated the nodes to qcm6490-idp board file.
> > - Link to v2: https://lore.kernel.org/all/20231110-qcom_leds-v2-1-3cad1fbbc65a@xxxxxxxxxxx/
> >
> > Changes in v2:
> > - Rephrased commit text and updated the nodes to board file.
> > - Link to v1: https://lore.kernel.org/r/20231108-qcom_leds-v1-1-c3e1c8572cb0@xxxxxxxxxxx
> > ---
> >   arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 23 +++++++++++++++++++++++
> >   1 file changed, 23 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> > index 37c91fdf3ab9..8268fad505e7 100644
> > --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> > @@ -5,6 +5,7 @@
> >
> >   /dts-v1/;
> >
> > +#include <dt-bindings/leds/common.h>
> >   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> >   #include "sc7280.dtsi"
> >   #include "pm7325.dtsi"
> > @@ -414,6 +415,28 @@ vreg_bob_3p296: bob {
> >          };
> >   };
> >
> > +&pm8350c_pwm {
> > +       function = LED_FUNCTION_STATUS;
> > +       #address-cells = <1>;
> > +       #size-cells = <0>;
> > +       status = "okay";
> > +
> > +       led@1 {
> > +               reg = <1>;
> > +               color = <LED_COLOR_ID_RED>;
> > +       };
> > +
> > +       led@2 {
> > +               reg = <2>;
> > +               color = <LED_COLOR_ID_GREEN>;
> > +       };
> > +
> > +       led@3 {
> > +               reg = <3>;
> > +               color = <LED_COLOR_ID_BLUE>;
> > +       };
> > +};
> > +
> >   &qupv3_id_0 {
> >          status = "okay";
> >   };
> >
> > ---
> > base-commit: 17cb8a20bde66a520a2ca7aad1063e1ce7382240
> > change-id: 20231215-lpg-4aadd374811a
> >
> > Best regards,
> > --
> > Hui Liu <quic_huliu@xxxxxxxxxxx>