Re: [PATCH v4 2/4] rcu: Add a trace event for synchronize_rcu_normal()

[Uladzislau Rezki]

On Sat, Jan 13, 2024 at 12:20:14AM +0100, Frederic Weisbecker wrote:
> Le Thu, Jan 04, 2024 at 05:25:08PM +0100, Uladzislau Rezki (Sony) a écrit :
> > Add an rcu_sr_normal() trace event. It takes three arguments
> > first one is the name of RCU flavour, second one is a user id
> > which triggeres synchronize_rcu_normal() and last one is an
> > event.
> > 
> > There are two traces in the synchronize_rcu_normal(). On entry,
> > when a new request is registered and on exit point when request
> > is completed.
> > 
> > Please note, CONFIG_RCU_TRACE=y is required to activate traces.
> > 
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@xxxxxxxxx>
> > ---
> >  include/trace/events/rcu.h | 27 +++++++++++++++++++++++++++
> >  kernel/rcu/tree.c          |  7 ++++++-
> >  2 files changed, 33 insertions(+), 1 deletion(-)
> > 
> > diff --git a/include/trace/events/rcu.h b/include/trace/events/rcu.h
> > index 2ef9c719772a..31b3e0d3e65f 100644
> > --- a/include/trace/events/rcu.h
> > +++ b/include/trace/events/rcu.h
> > @@ -707,6 +707,33 @@ TRACE_EVENT_RCU(rcu_invoke_kfree_bulk_callback,
> >  		__entry->rcuname, __entry->p, __entry->nr_records)
> >  );
> >  
> > +/*
> > + * Tracepoint for a normal synchronize_rcu() states. The first argument
> > + * is the RCU flavor, the second argument is a pointer to rcu_head the
> > + * last one is an event.
> > + */
> > +TRACE_EVENT_RCU(rcu_sr_normal,
> 
> Can we call this "synchronize_rcu" instead? So people really know what it's
> about.
> 
I will update it accordingly!

--
Uladzislau Rezki