Re: [PATCH v3 1/6] dt-bindings: display: add dt-bindings for STM32 LVDS device

From: Rob Herring
Date: Mon Jan 15 2024 - 09:33:05 EST



On Mon, 15 Jan 2024 14:20:04 +0100, Raphael Gallais-Pou wrote:
> Add "st,stm32mp25-lvds" compatible.
>
> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@xxxxxxxxxxx>
> ---
> Depends on: "dt-bindings: stm32: add clocks and reset binding for
> stm32mp25 platform" by Gabriel Fernandez
>
> Changes in v3:
> - Clarify commit dependency
> - Fix includes in the example
> - Fix YAML
> - Add "clock-cells" description
> - s/regroups/is composed of/
> - Changed compatible to show SoC specificity
>
> Changes in v2:
> - Switch compatible and clock-cells related areas
> - Remove faulty #include in the example.
> - Add entry in MAINTAINERS
> ---
> .../bindings/display/st,stm32-lvds.yaml | 119 ++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 120 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/st,stm32-lvds.yaml
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/display/st,stm32-lvds.example.dts:18:18: fatal error: dt-bindings/clock/st,stm32mp25-rcc.h: No such file or directory
18 | #include <dt-bindings/clock/st,stm32mp25-rcc.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/display/st,stm32-lvds.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1424: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240115132009.101718-2-raphael.gallais-pou@xxxxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.