Re: [PATCH 13/14] PCI: j721e: move reset GPIO to device struct

From: Andy Shevchenko
Date: Mon Jan 15 2024 - 15:09:39 EST


On Mon, Jan 15, 2024 at 6:16 PM Thomas Richard
<thomas.richard@xxxxxxxxxxx> wrote:
>
> From: Théo Lebrun <theo.lebrun@xxxxxxxxxxx>
>
> Move reset GPIO to device struct, so it can be used at suspend and
> resume stages.

..

> - struct gpio_desc *gpiod;

You can leave this and make the patch much lighter.

..

> if (ret != -EPROBE_DEFER)
> dev_err(dev, "Failed to get reset GPIO\n");

Side note (not related to this change): perhaps dev_err_probe()?

--
With Best Regards,
Andy Shevchenko