Re: [PATCH] drm/amd/display: Fix a switch statement in populate_dml_output_cfg_from_stream_state()

[Hamza Mahfooz]

On 1/13/24 09:58, Christophe JAILLET wrote:
> It is likely that the statement related to 'dml_edp' is misplaced. So move
> it in the correct "case SIGNAL_TYPE_EDP".
>
> Fixes: 7966f319c66d ("drm/amd/display: Introduce DML2")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Nice catch! Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
> index fa6a93dd9629..64d01a9cd68c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml2_translation_helper.c
> @@ -626,8 +626,8 @@ static void populate_dml_output_cfg_from_stream_state(struct dml_output_cfg_st *
>   		if (is_dp2p0_output_encoder(pipe))
>   			out->OutputEncoder[location] = dml_dp2p0;
>   		break;
> -		out->OutputEncoder[location] = dml_edp;
>   	case SIGNAL_TYPE_EDP:
> +		out->OutputEncoder[location] = dml_edp;
>   		break;
>   	case SIGNAL_TYPE_HDMI_TYPE_A:
>   	case SIGNAL_TYPE_DVI_SINGLE_LINK:
--
Hamza