Re: [PATCH] dt-bindings: rockchip: Fix Hardkernel ODROID-M1 board bindings

[Tim Lunn]

On 1/16/24 01:58, Krzysztof Kozlowski wrote:
> On 15/01/2024 15:51, KyuHyuk Lee wrote:
> > The vendor in ODROID-M1 is hardkernel, but it was incorrectly written
> > as rockchip. Fixed the vendor prefix correctly.
> >
> > Signed-off-by: KyuHyuk Lee <lee@xxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> You need to start testing your patches. Your last M1 fails as well in
> multiple places.
>
> It does not look like you tested the DTS against bindings. Please run
> `make dtbs_check W=1` (see
> Documentation/devicetree/bindings/writing-schema.rst or
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
> for instructions).
>
> The DTS change will break the users, so would be nice to mention this in
> its commit msg.

I notice there are a couple of other boards that incorrectly use 
rockchip as the vendor also:

          - const: rockchip,rk3399-orangepi
          - const: rockchip,rk3568-bpi-r2pro

Perhaps these should also be fixed at the same time?

Regards
  Tim

> Best regards,
> Krzysztof
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-rockchip