Re: [PATCH AUTOSEL 5.10 3/8] platform/chrome: cros_ec_debugfs: Fix permissions for panicinfo

From: Pavel Machek
Date: Tue Jan 16 2024 - 17:17:17 EST


Hi!

> From: Avadhut Naik <Avadhut.Naik@xxxxxxx>
>
> [ Upstream commit 0706526ec7704dcd046239078ac175d11a88a95e ]
>
> The debugfs_create_blob() function has been used to create read-only binary
> blobs in debugfs. The function filters out permissions, other than S_IRUSR,
> S_IRGRP and S_IROTH, provided while creating the blobs.
>
> The very behavior though is being changed through previous patch in the
> series (fs: debugfs: Add write functionality to debugfs blobs) which makes
> the binary blobs writable by owners. Thus, all permissions provided while
> creating the blobs, except S_IRUSR,S_IWUSR, S_IRGRP, S_IROTH, will be
> filtered by debugfs_create_blob().

This needs previous patch to make sense (according to changelog), and
we don't have that. Please drop.

BR,
Pavel

--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature