Re: [PATCH v3 1/3] gpio: vf610: add support to DT 'ngpios' property

From: Andy Shevchenko
Date: Wed Jan 17 2024 - 15:52:47 EST


On Wed, Jan 17, 2024 at 10:35 AM Hector Palacios
<hector.palacios@xxxxxxxx> wrote:
>
> Some SoCs, such as i.MX93, don't have all 32 pins available
> per port. Allow optional generic 'ngpios' property to be
> specified from the device tree and default to
> VF610_GPIO_PER_PORT (32) if the property does not exist.

..

> + ret = device_property_read_u32(dev, "ngpios", &ngpios);
> + if (ret || ngpios > VF610_GPIO_PER_PORT)
> + gc->ngpio = VF610_GPIO_PER_PORT;
> + else
> + gc->ngpio = (u16)ngpios;

This property is being read by the GPIOLIB core. Why do you need to repeat this?

--
With Best Regards,
Andy Shevchenko