Re: [PATCH] drm/msm/adreno: Add a null pointer check in zap_shader_load_mdt()

[Kunwu Chan]

On 2024/1/18 02:50, Markus Elfring wrote:
> > kasprintf() returns a pointer to dynamically allocated memory
> > which can be NULL upon failure. Ensure the allocation was successful
> > by checking the pointer validity.
> …
> > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> > @@ -144,6 +144,10 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname,
> >   		char *newname;
> >
> >   		newname = kasprintf(GFP_KERNEL, "qcom/%s", fwname);
> > +		if (!newname) {
> > +			ret = -ENOMEM;
> > +			goto out;
> > +		}
> …
>
> How do you think about to avoid the repetition of the pointer check
> for the variable “mem_region”?
"mem_region"? Is this a clerical error, do you mean 'newname'?

No check found in __qcom_mdt_load for 'newname'.
'newname' is used for printing in '__qcom_mdt_load' in some cases, which 
is a bit dangerous.
So it's necessary check it before using it.

> Can the usage of other labels become more appropriate?
>
> Regards,
> Markus
--
Thanks,
  Kunwu