Re: [PATCH v2] regulator: event: Add netlink command for event mask

From: Mark Brown
Date: Thu Jan 18 2024 - 09:20:28 EST


On Tue, Jan 16, 2024 at 02:46:41PM +0200, Matti Vaittinen wrote:
> On 1/16/24 12:31, Naresh Solanki wrote:

> > Add netlink command to enable perticular event(s) broadcasting instead

>
> I think this mechanism for limiting events being forwarded to the listener
> is worthy. My original idea was to utilize the netlink multicast groups for
> this so that the regulator core would register multiple multicast groups for
> this family. User would then listen only the groups he is interested, and
> multiplexing the messages would be done by netlink/socket code.

> Problem(?) of the approach you propose here is that the event filtering is
> global for all users. If multicast groups were used, this filtering would be
> done per listener socket basis. I'm not sure if that would be needed though,
> but somehow I feel it would be more usable for different user-land
> appliactions (cost being the increased complexity though).

Thinking about this some more I do think that global filtering like
the current patch would at least need some sort of permission check,
otherwise just any random process can disrupt everyone's monitoring.
Per socket filtering does seem like the way to go.

Attachment: signature.asc
Description: PGP signature