RE: [PATCH net v5 1/4] dpll: fix broken error path in dpll_pin_alloc(..)

From: Kubalewski, Arkadiusz
Date: Fri Jan 19 2024 - 08:50:24 EST


>From: Jiri Pirko <jiri@xxxxxxxxxxx>
>Sent: Thursday, January 18, 2024 12:33 PM
>
>Thu, Jan 18, 2024 at 12:07:16PM CET, arkadiusz.kubalewski@xxxxxxxxx wrote:
>>If pin type is not expected, or dpll_pin_prop_dup(..) failed to
>>allocate memory, the unwind error path shall not destroy pin's xarrays,
>>which were not yet initialized.
>>Add new goto label and use it to fix broken error path.
>>
>>Fixes: 9431063ad323 ("dpll: core: Add DPLL framework base functions")
>>Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@xxxxxxxxx>
>
>Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxx>

Thank you!
Arkadiusz