Re: [PATCH] string: Remove strlcpy()
From: Kees Cook
Date: Fri Jan 19 2024 - 14:58:48 EST
On Fri, Jan 19, 2024 at 06:05:19PM +0200, Andy Shevchenko wrote:
> On Fri, Jan 19, 2024 at 12:33 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> >
> > With all the users of strlcpy() removed[1] from the kernel, remove the
> > API, self-tests, and other references. Leave mentions in Documentation
> > (about its deprecation), and in checkpatch.pl (to help migrate host-only
> > tools/ usage). Long live strscpy().
>
> ...
>
> > * Copies at most dstsize - 1 bytes into the destination buffer.
> > - * Unlike strlcpy the destination buffer is always padded out.
> > + * Unlike strscpy the destination buffer is always padded out.
>
> While at it, please use the strscpy() form to refer to the function.
Oh, with the trailing "()"? Sure! Good call.
-Kees
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
Thanks!
-Kees
--
Kees Cook