Re: [PATCH v2] dt-bindings: PCI: ti,j721e-pci-host: Add support for J722S SoC

From: Siddharth Vadapalli
Date: Mon Jan 22 2024 - 05:01:56 EST


Hello Conor,

On 22/01/24 15:17, Conor Dooley wrote:
> On Mon, Jan 22, 2024 at 12:14:57PM +0530, Siddharth Vadapalli wrote:
>> TI's J722S SoC has one instance of a Gen3 Single-Lane PCIe controller.
>> The controller on J722S SoC is similar to the one present on TI's AM64
>> SoC, with the difference being that the controller on AM64 SoC supports
>> up to Gen2 link speed while the one on J722S SoC supports Gen3 link speed.
>>
>> Update the bindings with a new compatible for J722S SoC.
>
> Since the difference is just that this device supports a higher link
> speed, should it not have a fallback compatible to the am64 variant?
> Or is the programming model different for this device for the lower link
> speeds different?

Thank you for reviewing the patch. I shall add the same fallback compatible that
am64 has which is "ti,j721e-pcie-host". I will post the v3 patch with this
change if that's acceptable.

--
Regards,
Siddharth.