Re: [PATCH v5 3/3] iio: light: Add support for APDS9306 Light Sensor

[Subhajit Ghosh]

On 21/1/24 23:22, Andy Shevchenko wrote:
> On Sun, Jan 21, 2024 at 10:22:50AM +0100, Christophe JAILLET wrote:

> Seems like entire conditional here is not needed as it's implied in the max().
> And max() should take both signed or unsigned types, different types might have
> a side effect.
Ok, understood.
> > > +	/*
> > > +	 * Whichever is greater - integration time period or
> > > +	 * sampling period.
> > > +	 */
> > > +	delay = max(intg_time,
> > > +		    apds9306_repeat_rate_period[repeat_rate_idx]);
Thanks for the review.

Regards,
Subhajit Ghosh