Re: [PATCH V2 03/13] drivers: soundwire: amd: refactor amd soundwire manager device node creation

From: Vinod Koul
Date: Tue Jan 23 2024 - 02:16:13 EST


On 22-01-24, 17:18, Mukunda,Vijendar wrote:
> On 22/01/24 13:27, Vinod Koul wrote:
> > On 10-01-24, 15:14, Vijendar Mukunda wrote:

> >
> >> + * @count: link count
> >> + * @num_slaves: total number of devices exposed across all enabled links
> > should this be not per link?
> No, this will be total count of peripheral devices across all the links.
> This variable will be used in  snd_soc_acpi_sdw_link_slaves_found()
> API.

yeah noticed later

> >
> >> + * @link_mask: bit-wise mask listing SoundWire links reported by the
> >> + * Controller
> >> + * @ids: array of slave_id, representing Slaves exposed across all enabled
> >> + * links
> > this does not tell us which device to expect in which link..?
> sdw_extended_slave_id structure contains information about link id as well.

ok

--
~Vinod