Re: [PATCH AUTOSEL 6.1 08/14] ext4: enable dioread_nolock as default for bs < ps case

[Ojaswin Mujoo]

On Tue, Jan 16, 2024 at 09:47:44PM +0100, Pavel Machek wrote:
> Hi!
> > 
> > [ Upstream commit e89fdcc425b6feea4dfb33877e9256757905d763 ]
> > 
> > dioread_nolock was originally disabled as a default option for bs < ps
> > scenarios due to a data corruption issue. Since then, we've had some
> > fixes in this area which address such issues. Enable dioread_nolock by
> > default and remove the experimental warning message for bs < ps path.
> > 
> > dioread for bs < ps has been tested on a 64k pagesize machine using:
> > 
> > kvm-xfstest -C 3 -g auto
> > 
> > with the following configs:
> > 
> > 64k adv bigalloc_4k bigalloc_64k data_journal encrypt
> > dioread_nolock dioread_nolock_4k ext3 ext3conv nojournal
> > 
> > And no new regressions were seen compared to baseline kernel.
> 
> But no fixes, either, so not suitable for stable.
> 
> BR,
> 								Pavel

Hi Pavel, Sasha,

I agree, this can be dropped from stable since it is not a bug fix.

- ojaswin
> 
> -- 
> DENX Software Engineering GmbH,        Managing Director: Erika Unter
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany